This revision was automatically updated to reflect the committed changes.
Closed by commit rL318164: Add check for self-assignment. NFC (authored by
dhinton).
Repository:
rL LLVM
https://reviews.llvm.org/D39578
Files:
lldb/trunk/source/Core/RegisterValue.cpp
hintonda updated this revision to Diff 122730.
hintonda added a comment.
- Address comments.
https://reviews.llvm.org/D39578
Files:
source/Core/RegisterValue.cpp
source/Core/Value.cpp
Index: source/Core/Value.cpp
===
---
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
First change looks good. Second one we can probably avoid doing anything in
Value::AppendDataToHostBuffer and return 0. No need to copy data over itself.
hintonda added a comment.
ping?
https://reviews.llvm.org/D39578
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hintonda created this revision.
These two methods are essentially assignents, but don't check
for self-assignment and use memcpy for member variables.
Since they aren't actually operator=(), it's unclear what should be done:
- check and shortcut
- assert
- allow but s/memcpy/memmove/
