[Lldb-commits] [PATCH] D40519: Remove some duplicated code in UUID.cpp

2017-11-27 Thread Stephane Sezer via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319132: Remove some duplicated code in UUID.cpp (authored by sas). Repository: rL LLVM https://reviews.llvm.org/D40519 Files: lldb/trunk/source/Utility/UUID.cpp Index:

[Lldb-commits] [PATCH] D40519: Remove some duplicated code in UUID.cpp

2017-11-27 Thread Stephane Sezer via Phabricator via lldb-commits
sas updated this revision to Diff 124499. sas added a comment. Address @zturner's comment and remove a useless temporary variable. https://reviews.llvm.org/D40519 Files: source/Utility/UUID.cpp Index: source/Utility/UUID.cpp

[Lldb-commits] [PATCH] D40519: Remove some duplicated code in UUID.cpp

2017-11-27 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: source/Utility/UUID.cpp:77-78 void UUID::Dump(Stream *s) const { - const uint8_t *u = (const uint8_t *)GetBytes(); - s->Printf("%2.2X%2.2X%2.2X%2.2X-%2.2X%2.2X-%2.2X%2.2X-%2.2X%2.2X-%2.2X%2.2X%" -"2.2X%2.2X%2.2X%2.2X", -

[Lldb-commits] [PATCH] D40519: Remove some duplicated code in UUID.cpp

2017-11-27 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. LGTM https://reviews.llvm.org/D40519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D40519: Remove some duplicated code in UUID.cpp

2017-11-27 Thread Stephane Sezer via Phabricator via lldb-commits
sas created this revision. Formatting needs to be done only once. Ran check-lldb and nothing changes. https://reviews.llvm.org/D40519 Files: source/Utility/UUID.cpp Index: source/Utility/UUID.cpp === ---