Re: [Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

On 28 November 2017 at 17:28, Zachary Turner via lldb-commits wrote: > > > On Tue, Nov 28, 2017 at 2:48 AM Pavel Labath via Phabricator via > lldb-commits wrote: >> >> labath added a comment. >> >> On 28 November 2017 at 06:12, Zachary

[Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

clayborg added a comment. ok, this is fine then. Just need to test somehow. https://reviews.llvm.org/D40539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

sas added a comment. In https://reviews.llvm.org/D40539#937900, @clayborg wrote: > In https://reviews.llvm.org/D40539#937854, @sas wrote: > > > Basically, if you have a `.debug` directory in the same directory where the > > original object file is, you can have debug symbols there. For

[Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

clayborg added a comment. In https://reviews.llvm.org/D40539#937854, @sas wrote: > Basically, if you have a `.debug` directory in the same directory where the > original object file is, you can have debug symbols there. For instance, you > can have: > > /my/project/myElf.exe >

[Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

sas added a comment. Basically, if you have a `.debug` directory in the same directory where the original object file is, you can have debug symbols there. For instance, you can have: /my/project/myElf.exe /my/project/.debug/myElf.exe with the first file being a standard stripped elf file, and

[Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

clayborg added a comment. I am not sure I follow this patch. We are adding a FileSpec whose path is just the basename of the current ELF file? What do we do with that? Do we look in certain directories to try and find this file? How this this basename added to the list end up getting found in

Re: [Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

On Tue, Nov 28, 2017 at 2:48 AM Pavel Labath via Phabricator via lldb-commits wrote: > labath added a comment. > > On 28 November 2017 at 06:12, Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > yaml2core would be an excellent idea for a

[Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

aprantl added a comment. yaml2obj sounds generally like a good solution. I should note that right now yaml2obj is only used/tested for the (narrow) use-case of testing the linker. For creating debug-info-related testcases, I found it both to high and too low an abstraction. Too low, because it

[Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

labath added a comment. On 28 November 2017 at 06:12, Zachary Turner via lldb-commits wrote: > yaml2core would be an excellent idea for a tool. An (elf) core file is an elf file, with metadata in the elf program headers, so I think this would naturally fit into

Re: [Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

yaml2core would be an excellent idea for a tool. On Mon, Nov 27, 2017 at 9:48 PM Davide Italiano via Phabricator via lldb-commits wrote: > davide added subscribers: vsk, aprantl, davide. > davide added a comment. > > I thought about this, and it's the only patch

[Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

davide added subscribers: vsk, aprantl, davide. davide added a comment. I thought about this, and it's the only patch from your patchset that I don't feel really confident about. I'm afraid it's a little risky to add more code to the objectfile reader without having proper unittesting. In

[Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

sas created this revision. Herald added subscribers: JDevlieghere, emaste. In ObjectFileELF we try to read the `.gnu_debuglink` section of the ELF file to determine the name of the debug symbols file. If this section does not exist, we stop the search. Instead, what we should do is locate a file