This revision was automatically updated to reflect the committed changes.
Closed by commit rL322803: [CMake] Make check-lldb work with
LLDB_CODESIGN_IDENTITY= (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM with Adrian's suggestion applied, thanks for doing this!
https://reviews.llvm.org/D42215
___
lldb-commits mailing list
vsk updated this revision to Diff 130325.
vsk added a comment.
Thanks for the feedback!
-Print out the path to the debug server as a status message
https://reviews.llvm.org/D42215
Files:
docs/code-signing.txt
test/CMakeLists.txt
Index: test/CMakeLists.txt
jasonmolenda added a comment.
That's a good suggestion. We have some bots using the system debugserver --
and once in a while there's a change to both lldb and debugserver, and the bots
running the older prebuilt debugserver will fail any tests for that patchset.
aprantl added a comment.
How about printing a message (if CMAKE_HOST_APPLE) that the system debugserver
is being used at configure time?
https://reviews.llvm.org/D42215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
vsk created this revision.
vsk added reviewers: davide, aprantl, jasonmolenda.
Herald added a subscriber: mgorny.
On Darwin, if a test machine isn't set up for code-signing (see
docs/code-signing.txt), running check-lldb should use the system
debugserver instead of the unsigned one built in-tree.
