JDevlieghere closed this revision.
JDevlieghere added a comment.
Jup. Sorry for making it so confusing. Because Pavel's reply was here it seemed
sensible to update the diff.
Landed in https://reviews.llvm.org/rL324492
https://reviews.llvm.org/D43024
_
vsk reopened this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Ah, I see the first part landed in https://reviews.llvm.org/rL324488 and this
is a follow-up.
https://reviews.llvm.org/D43024
___
lldb-commits mailing
vsk accepted this revision.
vsk added a comment.
This lgtm Jonas, thank you!
https://reviews.llvm.org/D43024
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere updated this revision to Diff 133220.
JDevlieghere added a comment.
The change in r324488 dropped the existing category attribute in for
instance methods. This patch corrects that.
https://reviews.llvm.org/D43024
Files:
lldb/packages/Python/lldbsuite/test/decorators.py
Index: l
labath added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:307-308
"@add_test_categories can only be used to decorate a test
method")
if hasattr(func, "categories"):
cat.extend(func.categories)
+# Fo
JDevlieghere closed this revision.
JDevlieghere added a comment.
Forgot to add the differential to the commit message. Landed in
https://reviews.llvm.org/rL324488
Repository:
rL LLVM
https://reviews.llvm.org/D43024
___
lldb-commits mailing list
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
thanks for fixing this.
Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:526
return None
-
+
header = os.path.join(
---
JDevlieghere created this revision.
JDevlieghere added reviewers: vsk, davide, labath.
Herald added a subscriber: llvm-commits.
Inlined tests have a test function that is actually an instance method,
which requires a slightly different approach when it comes to setting
the category attribute. The
