jingham added a comment.
We'd get into problems on a platform other than MSVC that uses ^? for symbol
names that aren't C++ mangled ones - or equivalently if MSVC uses ^_Z for
non-C++ mangled names.
It looks like everywhere we use this (or use GuessLanguage) we either turn
around and mangle
Looks good (but for the _Z case, make sure its length is at least 2)
On Thu, Feb 8, 2018 at 12:33 PM Aaron Smith via Phabricator <
revi...@reviews.llvm.org> wrote:
> asmith added a comment.
>
> How about this?
>
> if (name == nullptr)
> return false;
>
> return ( (name[0] == '?') ||
asmith added a comment.
How about this?
if (name == nullptr)
return false;
return ( (name[0] == '?') || (name[0] == '_' && name[1] == 'Z') );
Repository:
rL LLVM
https://reviews.llvm.org/D43059
___
lldb-commits mailing list
I think just remove the preprocessor block. Imagine debugging a Windows
target from a linux host. This function would return false as written
because the host wasn’t Windows
On Thu, Feb 8, 2018 at 12:18 PM Aaron Smith via Phabricator <
revi...@reviews.llvm.org> wrote:
> asmith added a comment.
>
asmith added a comment.
IsCPPMangledName() is a public method to determine if a symbol has a mangled
name.
This change is needed so that lldb can find symbols with MSVC style mangled
names.
Open to suggestions on a better way to deal with this...
Here are all the places it is used:
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
That seems extremely dodgy. Surely whether something is a mangled name does not
depend on the compiler we built lldb with. I am aware that we have many places
with _Z hardcoded, but
davide added a comment.
Can you add a unittest for this? :)
Repository:
rL LLVM
https://reviews.llvm.org/D43059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
