[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek marked an inline comment as done. kubamracek added a comment. Thanks for the review! https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346695: [lldb] Extract more fields from NSException values (authored by kuba.brecka, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D43884 Files:

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek marked an inline comment as done. kubamracek added inline comments. Comment at: source/Plugins/Language/ObjC/NSException.cpp:161-168 +static ConstString g___name("name"); +static ConstString g___reason("reason"); static ConstString

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek updated this revision to Diff 173692. https://reviews.llvm.org/D43884 Files: packages/Python/lldbsuite/test/lang/objc/exceptions/Makefile packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py packages/Python/lldbsuite/test/lang/objc/exceptions/main.m

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

davide requested changes to this revision. davide added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/Language/ObjC/NSException.cpp:161-168 +static ConstString g___name("name"); +static ConstString g___reason("reason");

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a reviewer: aprantl. kubamracek added a comment. Ping. https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a comment. I simplified what this patch is doing by removing the other independent parts. I extended the test to be testing both CLI text output and SB APIs (which also means it cannot be moved to a lit test). https://reviews.llvm.org/D43884

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek updated this revision to Diff 136933. https://reviews.llvm.org/D43884 Files: packages/Python/lldbsuite/test/lang/objc/exceptions/Makefile packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py packages/Python/lldbsuite/test/lang/objc/exceptions/main.m

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a comment. The NFC refactoring part of this is at https://reviews.llvm.org/D44073. https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

jingham added inline comments. Comment at: source/Plugins/Language/ObjC/NSException.cpp:57-64 + auto name = process_sp->ReadPointerFromMemory(ptr + 1 * ptr_size, error); + if (error.Fail() || name == LLDB_INVALID_ADDRESS) return false; + auto reason =

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a comment. > This seems like it is two patches, one fixing the NSCallStackArray data > formatter, and one extracting fields from NSException. Is that right. I'm > more asking to make sure I'm not missing something about this patch. I'll split the patch. There's actually

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

jingham added a comment. For tests that run processes I don't think lit has any advantages over the dotest tests. For tests of a facility that's explicitly going to provide SB API's, testing them with dotest.py which is set up to be convenient to do SB API testing seems the correct thing to

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

davide added a comment. LG modulo the test. Update that, I'll take another look and approve it. Thanks for your contribution! Comment at: packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py:1-4 +# encoding: utf-8 +""" +Test lldb Obj-C exception support.

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added inline comments. Comment at: packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py:1-4 +# encoding: utf-8 +""" +Test lldb Obj-C exception support. +""" davide wrote: > This looks like it doesn't need any interactivity

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

davide added a comment. I like the way this patch is structured, some comments inline. Comment at: packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py:1-4 +# encoding: utf-8 +""" +Test lldb Obj-C exception support. +""" This looks like