clayborg added a comment.
Will we have the same problem with coff_symbol?
https://reviews.llvm.org/D44042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:511
+ // necessarily null-terminated
+ sect_name = std::string(sect.name,
clayborg added a comment.
Add test as well.
https://reviews.llvm.org/D44042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Just compile something with /Z7 and you'll get a section called `.debug$S` in
the object file, which is exactly 8 characters. Then teach lldb-test to dump
an object file's sections.
https://reviews.llvm.org/D44042
___
labath added a comment.
Is it possible to test this? Is it possible to make yaml2obj generate a file
that would trigger this?
https://reviews.llvm.org/D44042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.
good catch
https://reviews.llvm.org/D44042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
fjricci created this revision.
fjricci added reviewers: clayborg, zturner, wallace.
If a section name is exactly 8 characters (the maximum section name length),
and the next item in the section header struct contains a non-zero value,
we would append garbage data to the end of the section name
