labath added a comment.
I think a .ll file would be better abstraction level for this test. You can
still hardcode all the paths needed for the test while avoiding spelling out
the irrelevant details like debug info abbreviations. But I guess this will
work as well...
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327600: Fix a bug in target.source-map where we
would resolve unmapped paths… (authored by gclayton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
clayborg added a comment.
Committed revision 327600.
https://reviews.llvm.org/D44502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide accepted this revision.
davide added a comment.
LGTM, thanks
https://reviews.llvm.org/D44502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide added a comment.
(please wait a day or two if @labath has comments) but this should be fine.
https://reviews.llvm.org/D44502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This seems clearly right to me. Thanks for the test.
https://reviews.llvm.org/D44502
___
lldb-commits mailing list
clayborg added a comment.
The DWARF file that this produces has a DW_AT_comp_dir set to ".". This is
similar to how some builds work at Facebook when using Buck to build things.
https://reviews.llvm.org/D44502
___
lldb-commits mailing list
clayborg created this revision.
clayborg added reviewers: jingham, labath, lldb-commits.
When using:
(lldb) settings set target.source-map ./ /path/to/source
LLDB would fail to set a source file and line breakpoint with:
(lldb) breakpoint set --file /path/to/source/main.c --line 2
Because
