This revision was automatically updated to reflect the committed changes.
Closed by commit rL329891: Dont assume backing thread shares protocol ID.
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45497?vs=141982=142139#toc
Repository:
rL LLVM
JDevlieghere updated this revision to Diff 141982.
JDevlieghere added a comment.
- Address Greg's comment and factor out the method.
- Add a test case.
https://reviews.llvm.org/D45497
Files:
include/lldb/Target/ThreadList.h
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1826-1827
+for (size_t i = 0; i < num_threads; ++i) {
+ ThreadSP
JDevlieghere added a comment.
(I'll update the diff once I've figured out how to test this)
Repository:
rL LLVM
https://reviews.llvm.org/D45497
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
JDevlieghere created this revision.
JDevlieghere added reviewers: jingham, clayborg.
When we're dealing with virtual (memory) threads created by the OS
plugins, there's no guarantee that the real thread and the backing
thread share a protocol ID. Instead, we should iterate over the memory
threads
