[Lldb-commits] [PATCH] D45518: [dotest] Use in-tree dsymutil on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL329889: [dotest] Use in-tree dsymutil on Darwin (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D45518?vs=142037=142137#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D45518: [dotest] Use in-tree dsymutil on Darwin

davide accepted this revision. davide added a comment. LGTM https://reviews.llvm.org/D45518 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D45518: [dotest] Use in-tree dsymutil on Darwin

JDevlieghere updated this revision to Diff 142037. JDevlieghere added a comment. - Address Adrian's feedback https://reviews.llvm.org/D45518 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/dotest_args.py packages/Python/lldbsuite/test/make/Makefile.rules

[Lldb-commits] [PATCH] D45518: [dotest] Use in-tree dsymutil on Darwin

JDevlieghere added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:306 + if args.dsymutil: +os.environ['DSYMUTIL'] = args.dsymutil + else: aprantl wrote: > I suppose we could point to llvm-dsymutil even on non-darwin

[Lldb-commits] [PATCH] D45518: [dotest] Use in-tree dsymutil on Darwin

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:306 + if args.dsymutil: +os.environ['DSYMUTIL'] = args.dsymutil + else: I suppose we could point to llvm-dsymutil even on non-darwin platforms? Might be useful

[Lldb-commits] [PATCH] D45518: [dotest] Use in-tree dsymutil on Darwin

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, davide, jingham, labath. Herald added a subscriber: mgorny. With the upstream implementation of dsymutil containing almost all functionality from the one shipped with Xcode, we want to use the in-tree version for running