This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL330247: Report more precise error message when attach fails
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
jingham accepted this revision.
jingham added a comment.
That looks fine.
https://reviews.llvm.org/D45573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide added a comment.
lgtm
https://reviews.llvm.org/D45573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM module comment
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3809
}
// E01 code from vAttach means
labath created this revision.
labath added reviewers: jingham, JDevlieghere.
If the remote stub sends a specific error message instead of just a E??
code, we can use this to display a more informative error message
instead of just the generic "unable to attach" message.
I write a test for this
