[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

davide added subscribers: clayborg, jingham, jasonmolenda, labath. davide added a comment. thanks! Repository: rL LLVM https://reviews.llvm.org/D45592 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

thanks! On Fri, Apr 13, 2018 at 8:10 AM, Greg Clayton via Phabricator wrote: > clayborg marked 2 inline comments as done. > clayborg added a comment. > > Didn't update the diffs, but I did fix the things Davide requested before > submission > > > Repository: > rL

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

clayborg marked 2 inline comments as done. clayborg added a comment. Didn't update the diffs, but I did fix the things Davide requested before submission Repository: rL LLVM https://reviews.llvm.org/D45592 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rL330028: Allow relative file paths when settings source breakpoints (authored by gclayton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

davide added inline comments. Comment at: source/Breakpoint/BreakpointResolverFileLine.cpp:219-221 + if (is_relative) { +search_file_spec.GetDirectory().Clear(); + } For consistency with the rest of the codestyle (and what you use above), can you remove

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

davide added a comment. Thanks for this! Just one minor inline. Comment at: source/Breakpoint/BreakpointResolverFileLine.cpp:132 +if (is_relative) { + // If the path was reltive, make sure any matches match as long as the + // relative parts of the path match the

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D45592 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

clayborg updated this revision to Diff 142289. clayborg added a comment. Fixed the breakpoint verification in lldbutil to make sure the file name ends with the right thing https://reviews.llvm.org/D45592 Files: include/lldb/Breakpoint/BreakpointResolverFileLine.h

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

clayborg added inline comments. Comment at: packages/Python/lldbsuite/test/lldbutil.py:579 test.assertTrue( -file_name == out_file_name, +out_file_name in file_name, "Breakpoint file name '%s' doesn't match resultant name '%s'." %

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

jingham added a comment. Except for a minor comment, this seems fine to me, and is a useful addition! Comment at: packages/Python/lldbsuite/test/lldbutil.py:579 test.assertTrue( -file_name == out_file_name, +out_file_name in file_name,

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

clayborg created this revision. clayborg added reviewers: jingham, jasonmolenda, labath, lldb-commits. Herald added subscribers: JDevlieghere, aprantl. Many IDEs set breakpoints using absolute paths and this causes problems when the full path of the source file path doesn't match what is in the