This revision was automatically updated to reflect the committed changes.
Closed by commit rL331235: Refactor GetNextPersistentVariableName into a
non-virtual method (authored by adrian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
That's fine.
https://reviews.llvm.org/D46088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
aprantl updated this revision to Diff 144649.
aprantl added a comment.
Address review feedback.
https://reviews.llvm.org/D46088
Files:
include/lldb/Expression/ExpressionVariable.h
source/Core/ValueObject.cpp
source/Expression/ExpressionVariable.cpp
source/Expression/Materializer.cpp
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
I'm curious how you are going to implement GetPersistentVariablePrefix for a
language (e.g. swift) that uses multiple prefixes. You've got a pattern here
where you always call
aprantl added a comment.
ping
https://reviews.llvm.org/D46088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aprantl created this revision.
aprantl added a reviewer: jingham.
Refactor GetNextPersistentVariableName into a non-virtual method
that takes a prefix string. This simplifies the implementation and
allows plugins such as the Swift plugin to supply different prefixes
for return and error
