labath added a comment.
Looks great. Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D46529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331777: Add support to object files for accessing the
.debug_types section (authored by gclayton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
clayborg added a comment.
Pavel, let me know if you are good with this.
https://reviews.llvm.org/D46529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide accepted this revision.
davide added a comment.
Thanks for taking the time to split this!
https://reviews.llvm.org/D46529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
BTW: I added the .debug_info verification to the lit test as there was a
section made, but it wasn't checked.
https://reviews.llvm.org/D46529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg updated this revision to Diff 145715.
clayborg added a comment.
Added lit test.
https://reviews.llvm.org/D46529
Files:
include/lldb/lldb-enumerations.h
lit/Modules/elf-section-types.yaml
source/Core/Section.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thanks. Please also update the `lit/Modules/elf-section-types.yaml` test to
include the new section type.
https://reviews.llvm.org/D46529
___
clayborg created this revision.
clayborg added reviewers: labath, aprantl.
Herald added subscribers: JDevlieghere, arichardson, emaste.
Herald added a reviewer: espindola.
In an effort to make the .debug_types patch smaller, breaking out the part that
reads the .debug_types from object files
