This revision was automatically updated to reflect the committed changes.
Closed by commit rL331892: General cleanup to minimize the .debug_types patch
(authored by gclayton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Looks like this is bringing the interface a *little* closer to the llvm one.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h:40
+
clayborg updated this revision to Diff 145926.
clayborg added a comment.
Remove check for NULL cu_sp shared pointer as Pavel noted.
https://reviews.llvm.org/D46606
Files:
include/lldb/lldb-forward.h
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
labath added a comment.
This looks fine to me. I am not clicking accept yet, so other debug info folks
can take a look at this too.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:28
// Out of memory?
- if (cu_sp.get() == NULL)
+ if (!cu_sp)
return
clayborg created this revision.
clayborg added reviewers: labath, aprantl.
Herald added a subscriber: JDevlieghere.
This cleanup is designed to make the https://reviews.llvm.org/D32167 patch
smaller and easier to read.
Cleanup in this patch:
Allow DWARFUnit subclasses to hand out the data that
