This revision was automatically updated to reflect the committed changes.
Closed by commit rL333583: [lldb-test] Add a testing harness for the JITs
IRMemoryMap (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thank you for making the changes. This looks fine to me. The more testing, the
better.
Comment at: tools/lldb-test/lldb-test.cpp:532
+ // Print the result of the
vsk updated this revision to Diff 149173.
vsk edited the summary of this revision.
vsk added a comment.
- Really fix the allocation overlap test. The previous version of this patch
would not detect overlaps in which the end of the new allocation is contained
within an existing allocation.
>
vsk updated this revision to Diff 149159.
vsk edited the summary of this revision.
vsk added a comment.
- Use %zu, and improve detection of overlapping allocations.
https://reviews.llvm.org/D47508
Files:
lit/Expr/TestIRMemoryMap.test
source/Target/Process.cpp
labath added a comment.
The idea that came to me while looking at this is testing this gdb-client
style. This would allow you to mock the server responses to allocation and e.g.
test handling of allocation failures. However, the problem is these tests sit
on top of SBAPI and there seems to be
