This revision was automatically updated to reflect the committed changes.
Closed by commit rL333968: Change SWIG output directory when building
LLDB.framework with CMake (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/
sas added inline comments.
Comment at: scripts/CMakeLists.txt:38
OUTPUT ${LLDB_WRAP_PYTHON}
- OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lldb.py
DEPENDS ${SWIG_SOURCES}
xiaobai wrote:
> sas wrote:
> > ...and this path were not the same before your change. Was that
xiaobai added inline comments.
Comment at: scripts/CMakeLists.txt:38
OUTPUT ${LLDB_WRAP_PYTHON}
- OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lldb.py
DEPENDS ${SWIG_SOURCES}
sas wrote:
> ...and this path were not the same before your change. Was that a bug that
>
sas accepted this revision.
sas added inline comments.
This revision is now accepted and ready to land.
Comment at: CMakeLists.txt:149
DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py
-DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/scripts/lldb.py
xiaobai added reviewers: labath, sas.
xiaobai added a comment.
I'm not sure who else would be interested in reviewing this. If you know
somebody, please add them. :)
https://reviews.llvm.org/D47742
___
lldb-commits mailing list
lldb-commits@lists.l
xiaobai created this revision.
xiaobai added a reviewer: clayborg.
Herald added a subscriber: mgorny.
Instead of assuming that SWIG generated files (e.g. lldb.py) will live
in scripts, we should set it to $LLDB_PYTHON_TARGET_DIR. This variable is set to
scripts, except when building LLDB.framework
