aprantl added a comment.
I'm getting a new warning now, can you also reproduce this?
In file included from :21:
In file included from ../tools/lldb/include/lldb/Host/MainLoop.h:13:
tools/lldb/include/lldb/Host/Config.h:33:9: warning: 'HAVE_LIBCOMPRESSION'
macro redefined
teemperor updated this revision to Diff 151181.
teemperor added a comment.
- Finally found the one and only way to spell "Objective-C++"
https://reviews.llvm.org/D47929
Files:
include/lldb/module.modulemap
source/Host/CMakeLists.txt
source/Host/common/Terminal.cpp
teemperor updated this revision to Diff 151077.
teemperor added a comment.
- The regex that removes the modules cache now actually removes the whole flag
+ path.
- Fixed more typos.
https://reviews.llvm.org/D47929
Files:
include/lldb/module.modulemap
source/Host/CMakeLists.txt
aprantl added inline comments.
Comment at: source/Host/CMakeLists.txt:7
+# Removes all module flags from the current CMAKE_CXX_FLAGS. Used for
+# the Obj-C++ code in lldb which we don't want to build with modules.
+# Reasons for this are that modules with Obj-C++ would require
teemperor updated this revision to Diff 151025.
teemperor marked an inline comment as done.
teemperor added a comment.
- Fixed a typo.
https://reviews.llvm.org/D47929
Files:
include/lldb/module.modulemap
source/Host/CMakeLists.txt
source/Host/common/Terminal.cpp
teemperor updated this revision to Diff 151023.
teemperor added a comment.
- Obj-C -> Obj-C++
https://reviews.llvm.org/D47929
Files:
include/lldb/module.modulemap
source/Host/CMakeLists.txt
source/Host/common/Terminal.cpp
source/Host/macosx/Host.mm
aprantl accepted this revision.
aprantl added inline comments.
Comment at: source/Host/CMakeLists.txt:7
+# Removes all module flags from the current CMAKE_CXX_FLAGS. Used for
+# the Obj-C++ code in lldb which we don't want to build with modules.
+# Reasons for this are that
teemperor added inline comments.
Comment at: include/lldb/module.modulemap:66
+// This big module is necessary to work around the cyclic dependencies
+// between its submodules.
+module lldb {
teemperor wrote:
> bruno wrote:
> > Will this trick be enough for
teemperor updated this revision to Diff 151004.
teemperor retitled this revision from "Add modulemap to lldb include directory"
to "Add modules support for lldb headers in include/".
teemperor edited the summary of this revision.
teemperor added a comment.
This revision is now accepted and ready
