This revision was automatically updated to reflect the committed changes.
Closed by commit rL338591: Don't ignore byte_order in Stream::PutMaxHex64
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50025?vs=158563
teemperor updated this revision to Diff 158563.
teemperor added a comment.
- Updated patch to reflect code changes in the parent commit.
https://reviews.llvm.org/D50025
Files:
source/Utility/Stream.cpp
unittests/Utility/StreamTest.cpp
Index: unittests/Utility/StreamTest.cpp
==
teemperor updated this revision to Diff 158126.
teemperor edited the summary of this revision.
teemperor added a comment.
- Reverse patch dependencies that we can add the unit test here (but also means
this has to wait until the StreamTest is in).
https://reviews.llvm.org/D50025
Files:
sourc
teemperor added a comment.
Yeah, on a second thought I should just strip out the parts of the unit test
that found this bug and commit them alongside this.
https://reviews.llvm.org/D50025
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
zturner added a comment.
When is the Stream unit test coming? Maybe we should just add it first, then
add this?
https://reviews.llvm.org/D50025
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
teemperor created this revision.
Note: We don't have a unittest for Stream yet, so the regression test for this
will be added with the
upcoming Stream unit test.
https://reviews.llvm.org/D50025
Files:
source/Utility/Stream.cpp
Index: source/Utility/Stream.cpp
==
