This revision was automatically updated to reflect the committed changes.
Closed by commit rL338590: [StackFrame] Add doxygen comments to the
StackFrameList API (NFC) (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
vsk added a comment.
In https://reviews.llvm.org/D50087#1183982, @labath wrote:
> I am not too familiar with this code, but the descriptions seem to make sense.
>
> However, since you have kind of opened up the `Optional` discussion, I'll use
> this opportunity to give my take on it:
>
> I've
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I am not too familiar with this code, but the descriptions seem to make sense.
However, since you have kind of opened up the `Optional` discussion, I'll use
this opportunity to give my take
vsk created this revision.
vsk added reviewers: labath, jasonmolenda, tberghammer.
Clarify how StackFrameList works by documenting its methods. Also,
delete some dead code and insert some TODOs.
https://reviews.llvm.org/D50087
Files:
lldb/include/lldb/Target/StackFrameList.h
