[Lldb-commits] [PATCH] D50473: [Demangle] Add another test for ItaniumPartialDemangler

2018-08-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. BTW: warning I saw during recent build: [98/790] Building CXX object tools/lldb/source/Core/CMakeFiles/lldbCore.dir/RichManglingContext.cpp.o /home/gclayton/local/src/llvm/svn/llvm/tools/lldb/source/Core/RichManglingContext.cpp: In member function ‘bool

[Lldb-commits] [PATCH] D50473: [Demangle] Add another test for ItaniumPartialDemangler

2018-08-08 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL339297: [Demangle] Add another test for ItaniumPartialDemangler (authored by stefan.graenitz, committed by ). Repository: rL LLVM https://reviews.llvm.org/D50473 Files:

[Lldb-commits] [PATCH] D50473: [Demangle] Add another test for ItaniumPartialDemangler

2018-08-08 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added inline comments. Comment at: unittests/Demangle/PartialDemangleTest.cpp:188 +size_t N = OriginalSize; +char *Res = D.getFunctionName(Buf, ); +EXPECT_EQ(nullptr, Res); erik.pilkington wrote: > Does LLDB actually pass in a N that is

[Lldb-commits] [PATCH] D50473: [Demangle] Add another test for ItaniumPartialDemangler

2018-08-08 Thread Erik Pilkington via Phabricator via lldb-commits
erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this! Comment at: unittests/Demangle/PartialDemangleTest.cpp:188 +size_t N = OriginalSize; +char *Res =

[Lldb-commits] [PATCH] D50473: [Demangle] Add another test for ItaniumPartialDemangler

2018-08-08 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. sgraenitz added a reviewer: erik.pilkington. Herald added a subscriber: llvm-commits. Show the behavior of print operations in the ItaniumPartialDemangler. It's a summary of what the current integration in LLDB assumes. For new users this may be a useful