This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB342508: Allow use of self.filecheck in LLDB tests (c.f
self.expect) (authored by vedantk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50751?vs=165613=166017#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342508: Allow use of self.filecheck in LLDB tests (c.f
self.expect) (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM minus one small detail (see inline comment). Thanks Vedant!
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:51
import sys
+import tempfile
import
JDevlieghere accepted this revision.
JDevlieghere added a comment.
Thanks Vedant, this looks very useful!
https://reviews.llvm.org/D50751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
stella.stamenova accepted this revision.
stella.stamenova added a comment.
LGTM, but I'd wait till @teemperor approves as well.
https://reviews.llvm.org/D50751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
vsk updated this revision to Diff 165613.
vsk marked 6 inline comments as done.
vsk added a comment.
Herald added a subscriber: mgorny.
Sorry for the delay, I was busy with other work. I think I've addressed the
review feedback. PTAL.
https://reviews.llvm.org/D50751
Files:
stella.stamenova added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:194
+# of the test build dir is the LLVM build dir.
+llvm_build_dir = os.path.dirname(os.path.abspath(test_build_dir))
+assert
teemperor requested changes to this revision.
teemperor added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:194
+# of the test build dir is the LLVM build dir.
+llvm_build_dir =
vsk updated this revision to Diff 162491.
vsk retitled this revision from "WIP: Expose FileCheck-style testing within
lldb inline tests" to "Allow use of self.filecheck in LLDB tests (c.f
self.expect)".
vsk edited the summary of this revision.
vsk added reviewers: teemperor, aprantl, zturner.
