This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB340966: Dont include the Age in the UUID for
CvRecordPdb70 UUID records in minidump… (authored by gclayton, committed by ).
Changed prior to commit:
lemo accepted this revision.
lemo added a comment.
This revision is now accepted and ready to land.
Looks good (with one inline request for a comment)
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:85
+ auto arch = GetArchitecture();
+ if
clayborg added a comment.
In https://reviews.llvm.org/D51442#1217894, @lemo wrote:
> I'm curious too: where did the PDB70 age create matching problems?
For breakpad ARM and ARM64 minidumps that are for Apple vendor triples.
> On a related note, I just noticed that ObjectFilePECOFF::GetUUID()
clayborg updated this revision to Diff 163143.
clayborg added a comment.
Make 16 byte UUIDs Apple specific.
https://reviews.llvm.org/D51442
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
Index: source/Plugins/Process/minidump/MinidumpParser.cpp
clayborg added a comment.
In https://reviews.llvm.org/D51442#1217829, @zturner wrote:
> For PE/COFF files, the Age is also in the executable and Guid+Age actually
> constitute a 20-byte UUID. Is this not the case on Apple? What object file
> format are you dealing with?
Breakpad files that
We probably don't. Windows debug info in LLDB is currently based off of
DIA SDK, which handles everything for us (but obviously only works on
Windows). That's one of the things that would need to be fixed to debug
Windows minidumps on Linux (I assume).
On Wed, Aug 29, 2018 at 10:47 AM Leonard
lemo added a subscriber: zturner.
lemo added a comment.
I'm curious too: where did the PDB70 age create matching problems?
On a related note, I just noticed that ObjectFilePECOFF::GetUUID() doesn't
have a real implementation (just returns false). How do we extract module
UUID for PE/COFF files?
I'm curious too: where did the PDB70 age create matching problems?
On a related note, I just noticed that ObjectFilePECOFF::GetUUID() doesn't
have a real implementation (just returns false). How do we extract module
UUID for PE/COFF files?
On Wed, Aug 29, 2018 at 10:28 AM, Zachary Turner via
For PE/COFF files, the Age is also in the executable and Guid+Age actually
constitute a 20-byte UUID. Is this not the case on Apple? What object file
format are you dealing with?
On Wed, Aug 29, 2018 at 10:11 AM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg created
zturner added a subscriber: clayborg.
zturner added a comment.
For PE/COFF files, the Age is also in the executable and Guid+Age actually
constitute a 20-byte UUID. Is this not the case on Apple? What object file
format are you dealing with?
https://reviews.llvm.org/D51442
clayborg created this revision.
clayborg added reviewers: zturner, labath, dvlahovski, lemo.
The CvRecordPdb70 structure looks like:
struct CvRecordPdb70 {
uint8_t Uuid[16];
llvm::support::ulittle32_t Age;
// char PDBFileName[];
};
We are currently including the "Age" in the
11 matches
Mail list logo
