[Lldb-commits] [PATCH] D51461: Support setting a breakpoint by FileSpec+Line+Column in the SBAPI.

2018-08-30 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341078: Support setting a breakpoint by FileSpec+Line+Column in the SBAPI. (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D51461: Support setting a breakpoint by FileSpec+Line+Column in the SBAPI.

2018-08-29 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That's great, thanks! https://reviews.llvm.org/D51461 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D51461: Support setting a breakpoint by FileSpec+Line+Column in the SBAPI.

2018-08-29 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl updated this revision to Diff 163231. aprantl marked 4 inline comments as done. aprantl added a comment. Address review feedback. https://reviews.llvm.org/D51461 Files: include/lldb/API/SBTarget.h include/lldb/Breakpoint/BreakpointResolver.h

[Lldb-commits] [PATCH] D51461: Support setting a breakpoint bile FileSpec+Line+Column in the SBAPI.

2018-08-29 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl created this revision. aprantl added a reviewer: jingham. Herald added subscribers: abidh, mgrang. Support setting a breakpoint bile FileSpec+Line+Column in the SBAPI. This patch extends the SBAPI to allow for setting a breakpoint not only at a specific line, but also at a specific