This revision was automatically updated to reflect the committed changes.
Closed by commit rL343860: TestMultilineExpr: validate evaluation for
expressions that span multiple lines (authored by stefan.graenitz, committed by
).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
sgraenitz marked an inline comment as done.
sgraenitz added a comment.
Requires: https://reviews.llvm.org/D52788 (Add EchoCommentCommands to
CommandInterpreterRunOptions in addition to the existing EchoCommands and
expose both as interpreter settings)
https://reviews.llvm.org/D52270
sgraenitz updated this revision to Diff 168466.
sgraenitz added a comment.
Simplify test as proposed in review
https://reviews.llvm.org/D52270
Files:
lit/Expr/TestMultilineExpr.test
packages/Python/lldbsuite/test/expression_command/multiline/Makefile
sgraenitz added a comment.
In https://reviews.llvm.org/D52270#1239685, @aprantl wrote:
> What do you think about fixing that before landing this patch? Then we don't
> need to work around it.
Hm, we didn't finally decide for the fix and I don't want to raise the pressure
on it artificially.
aprantl added a comment.
> LLDB still echoes all commands including comments
What do you think about fixing that before landing this patch? Then we don't
need to work around it.
https://reviews.llvm.org/D52270
___
lldb-commits mailing list
sgraenitz added a comment.
In https://reviews.llvm.org/D52270#1239641, @teemperor wrote:
> Can't you just check for '5', as this is the only information we actually
> actually care about here?
Yes that would be the simplest way, but as LLDB still echoes all commands
including comments, all
aprantl added a comment.
For those following at home: the point of this exercise is to get rid of the
-expect-based TestMultilineExpressions.py testcase that kept failing on build
bots.
https://reviews.llvm.org/D52270
___
lldb-commits mailing
sgraenitz updated this revision to Diff 166155.
sgraenitz added a comment.
Remove old Python test in
./packages/Python/lldbsuite/test/expression_command/multiline/
https://reviews.llvm.org/D52270
Files:
lit/Expr/TestMultilineExpr.test
teemperor added a comment.
Can't you just check for '5', as this is the only information we actually
actually care about here?
https://reviews.llvm.org/D52270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
sgraenitz marked 3 inline comments as done.
sgraenitz added inline comments.
Comment at: lit/Expr/TestMultilineExpr.test:9
+# CHECK: (lldb) expression
+# CHECK-NEXT: Enter expressions, then terminate with an empty line to evaluate:
+# CHECK-NEXT: (int) {{.*}} = 5
aprantl added a comment.
Does that mean we can remove
./packages/Python/lldbsuite/test/expression_command/multiline/TestMultilineExpressions.py
?
https://reviews.llvm.org/D52270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
sgraenitz updated this revision to Diff 166151.
sgraenitz added a comment.
Addressing Adrian's comments
https://reviews.llvm.org/D52270
Files:
lit/Expr/TestMultilineExpr.test
Index: lit/Expr/TestMultilineExpr.test
===
---
aprantl added inline comments.
Comment at: lit/Expr/TestMultilineExpr.test:3
+
+# In terminal sessions LLDB reverts input from subsequent lines so it doesn't
show up in the output we check below.
+expression
"reverts" -> "joins"?
Comment at:
aprantl added inline comments.
Comment at: lit/Expr/TestMultilineExpr.test:3
+
+# In terminal sessions LLDB reverts input from subsequent lines so it doesn't
show up in the output we check below.
+expression
aprantl wrote:
> "reverts" -> "joins"?
or did you
sgraenitz created this revision.
sgraenitz added reviewers: vsk, davide, aprantl.
When LLDB successfully parses a command (like "expression" in this case) and
determines incomplete input, the user can continue typing on multiple lines (in
this case "2+3"). This should provide the correct
15 matches
Mail list logo
