This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344328: [LLDB] - Add support for DW_FORM_implicit_const.
(authored by grimar, committed by ).
Herald added a subscriber: abidh.
Changed prior to commit:
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Thanks for making the changes. Looks good!
https://reviews.llvm.org/D52689
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
grimar updated this revision to Diff 169209.
grimar added a comment.
- Addressed review comments.
https://reviews.llvm.org/D52689
Files:
lit/Breakpoint/Inputs/implicit_const_form_support.yaml
lit/Breakpoint/implicit_const_form_support.test
clayborg added a comment.
Down to just modifying the DWARFFormValue constructor to be able to take a CU
only. Looks good.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:241-242
+for (uint32_t i = 0; i < numAttributes; ++i) {
+
grimar added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:23
+ DWARFAttribute(dw_attr_t attr, dw_form_t form,
+ DWARFFormValue::ValueType value)
+ : m_attr(attr), m_form(form), m_value(value) {}
clayborg
grimar updated this revision to Diff 169177.
grimar marked 4 inline comments as done.
grimar added a comment.
- Addressed review comments.
https://reviews.llvm.org/D52689
Files:
lit/Breakpoint/Inputs/implicit_const_form_support.yaml
lit/Breakpoint/implicit_const_form_support.test
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few things inlined. Very close. DumpAttribute will need to take a
DWARFFormValue in order to dump the value correctly.
Comment at:
grimar added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:51
+ uint32_t idx, dw_attr_t , dw_form_t ,
+ DWARFFormValue::ValueType *val = nullptr) const {
+m_attributes[idx].get(attr, form, val);
grimar updated this revision to Diff 169005.
grimar marked 12 inline comments as done.
grimar added a comment.
- Addressed review comments.
https://reviews.llvm.org/D52689
Files:
lit/Breakpoint/Inputs/implicit_const_form_support.yaml
lit/Breakpoint/implicit_const_form_support.test
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:51
+ uint32_t idx, dw_attr_t , dw_form_t ,
+
grimar added a comment.
Ping.
https://reviews.llvm.org/D52689
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
grimar added a comment.
In https://reviews.llvm.org/D52689#1253175, @vsk wrote:
> Could you describe how the test exercises DW_FORM_implicit_const support?
> It's not immediately clear to me.
The abbreviation for `foo1` and `foo2` subprograms use it for `DW_AT_decl_file`
and
vsk added a comment.
Could you describe how the test exercises DW_FORM_implicit_const support? It's
not immediately clear to me.
https://reviews.llvm.org/D52689
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
grimar created this revision.
grimar added reviewers: LLDB, clayborg.
Herald added subscribers: JDevlieghere, aprantl.
LLDB does not support this DWARF5 form atm.
At least gcc emits it in some cases when doing optimization
for abbreviations.
As far I can tell, clang does not support it yet,
14 matches
Mail list logo
