This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rLLDB352021: BreakpadRecords: Address post-commit feedback
(authored by labath, committed by ).
Changed prior to commit:
>
> After some internal discussion, it seems that the situation with the
> all-zero UUIDs is as follows:
> - breakpad symbol files do not attach a special meaning to a zero UUID -
> if a file does not have a build-id, the dump_syms tool will use a hash of
> the first page of the text section (or
labath marked 5 inline comments as done.
labath added a comment.
After some internal discussion, it seems that the situation with the all-zero
UUIDs is as follows:
- breakpad symbol files do not attach a special meaning to a zero UUID - if a
file does not have a build-id, the dump_syms tool
lemo accepted this revision.
lemo added a comment.
This revision is now accepted and ready to land.
Looks good - the all-zero UUID case is a bit unfortunate but it seems we have
to handle it (like Greg suggested)
Comment at:
labath marked an inline comment as done.
labath added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:87-97
// The textual module id encoding should be between 33 and 40 bytes long,
// depending on the size of the age field, which is of
clayborg added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:87-97
// The textual module id encoding should be between 33 and 40 bytes long,
// depending on the size of the age field, which is of variable length.
// The first three
labath marked 2 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:67
+/// to the endian-specific integer N. Return true on success.
+template static bool consume_integer(llvm::StringRef , T ) {
+
clayborg added a comment.
Let me know what you think of the UUID code and if you want to include that in
this patch
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:67
+/// to the endian-specific integer N. Return true on success.
+template static bool
labath updated this revision to Diff 182847.
labath added a comment.
rebase
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57037/new/
https://reviews.llvm.org/D57037
Files:
source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp
source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h
