[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

stella.stamenova added a comment. This is causing a failure on the Windows Bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2299/steps/test/logs/stdio It was broken because of another change which is why you probably didn't get a notification. Please, fix this quickly or

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL355402: Adds property to force enabling of GDB JIT loader for MacOS (authored by yurydelendik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik updated this revision to Diff 189244. yurydelendik added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 Files:

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Yes, looks fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik added a comment. Herald added a subscriber: jdoerfert. @jingham is this patch good to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 ___

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

labath added a comment. In D57689#1389212 , @yurydelendik wrote: > In D57689#1384894 , @labath wrote: > > > Do we need both this and the `enable-jit-breakpoint` setting? My impression > > was that the latter was

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik added a comment. In D57689#1384148 , @jingham wrote: > Could you add a test for this setting to the > ./functionalities/jitloader_gdb/TestJITLoaderGDB.py test? Added tests In D57689#1384894 ,

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik updated this revision to Diff 185809. yurydelendik added a comment. - Remove enable-jit-breakpoint option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 Files:

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik updated this revision to Diff 185807. yurydelendik added a comment. Herald added a reviewer: serge-sans-paille. - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 Files:

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

labath added a comment. Do we need both this and the `enable-jit-breakpoint` setting? My impression was that the latter was meant to be used for disabling the gdb jit feature. Is the gdb plugin useful for anything if it does not set the breakpoint (i.e. enable = on, but enable-jit-bkpt = off).

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

jingham added a comment. That looks good. Could you add a test for this setting to the ./functionalities/jitloader_gdb/TestJITLoaderGDB.py test? I wouldn't test that the default has any particular behavior because that might change over time. But test that if you turn it on, you do get load

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik updated this revision to Diff 185164. yurydelendik added a comment. - Change to on/off/default property. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 Files:

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. It would be better to have the setting be an enum of "on/off/default", and then have the somebody - the current DynamicLoader plugin seems the best somebody - provide the default

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik updated this revision to Diff 185053. yurydelendik added a comment. Fix GetEnableLoaderForDarwin name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 Files:

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Based on https://gist.github.com/thlorenz/30bf0a3f67b1d97b2945#patching-and-rebuilding The functionality was disabled at