Re: [Lldb-commits] [PATCH] D58727: https://reviews.llvm.org/D58394 done right

2019-03-04 Thread Jim Ingham via lldb-commits
The event we are stopping for is the stop to single step over a breakpoint. We should have decided not to broadcast that to the public event queue, since it's an implementation stop of the "continue". It almost looks like the stop hook is getting triggered by a not-broadcast event, though

[Lldb-commits] [PATCH] D58727: https://reviews.llvm.org/D58394 done right

2019-03-01 Thread Jim Ingham via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355213: Resubmit r354706 with a fix for process launch. (authored by jingham, committed by ). Herald added a subscriber: teemperor. Changed prior to commit:

[Lldb-commits] [PATCH] D58727: https://reviews.llvm.org/D58394 done right

2019-03-01 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Excellent, thanks! I didn't think to look there. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58727/new/ https://reviews.llvm.org/D58727 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D58727: https://reviews.llvm.org/D58394 done right

2019-03-01 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, that did the trick. The new test is passing on linux now as well. Regarding BTW, I see the option to "reopen a revision" in the drop down menu at the bottom of the page (the same one you

[Lldb-commits] [PATCH] D58727: https://reviews.llvm.org/D58394 done right

2019-02-27 Thread Jim Ingham via Phabricator via lldb-commits
jingham created this revision. jingham added a reviewer: labath. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. I was running the lit tests by hand (since you can't actually run them with the Xcode build) and missed one crucial fact. The lit tests are all run in