[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL355342: Move ProcessInfo from Host to Utility. (authored by zturner, committed by ). Herald added a project: LLVM. Herald

[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

labath added a comment. In D58842#1415542 , @zturner wrote: > In D58842#1415526 , @labath wrote: > > > Hmm.. I think I've thought of (or remembered, because I have been thinking > > about Utility too) a reason why

[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

zturner added a comment. In D58842#1415526 , @labath wrote: > Hmm.. I think I've thought of (or remembered, because I have been thinking > about Utility too) a reason why it might be better to keep these in Host. > ProcessLaunchInfo cannot be trivially

[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

labath added a comment. Hmm.. I think I've thought of (or remembered, because I have been thinking about Utility too) a reason why it might be better to keep these in Host. ProcessLaunchInfo cannot be trivially moved to Utility (and indeed, in this patch, you are keeping it in Host), because

[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

labath added a comment. My main reason for creating D58167 was so that this move (*) could be done without leaving the remnants of the Dump function in the form DumpProcessInstance functions in Process.cpp (among other benefits I think that refactoring will

[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

zturner created this revision. zturner added reviewers: jingham, labath, JDevlieghere. Herald added subscribers: jdoerfert, mgorny, emaste. There are set of classes in Target that describe the parameters of a process - e.g. it's PID, name, user id, and similar. However, since it is a bare