[Lldb-commits] [PATCH] D58912: [debugserver] Fix IsUserReady thread filtering

2019-03-06 Thread Frederic Riss via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB35: [debugserver] Fix IsUserReady thread filtering (authored by friss, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D58912: [debugserver] Fix IsUserReady thread filtering

2019-03-04 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good, that was my only concern. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58912/new/ https://reviews.llvm.org/D58912

[Lldb-commits] [PATCH] D58912: [debugserver] Fix IsUserReady thread filtering

2019-03-04 Thread Frederic Riss via Phabricator via lldb-commits
friss added a comment. In D58912#1417570 , @jasonmolenda wrote: > Will this hide a thread that jumps through a null function pointer? That's > the only user process case where a pc of 0 needs to be reported to the > developer. Nope, I tested this

[Lldb-commits] [PATCH] D58912: [debugserver] Fix IsUserReady thread filtering

2019-03-04 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. Will this hide a thread that jumps through a null function pointer? That's the only user process case where a pc of 0 needs to be reported to the developer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58912/new/ https://reviews.llvm.org/D58912

[Lldb-commits] [PATCH] D58912: [debugserver] Fix IsUserReady thread filtering

2019-03-04 Thread Frederic Riss via Phabricator via lldb-commits
friss created this revision. friss added reviewers: jasonmolenda, clayborg, jingham. Herald added a subscriber: jdoerfert. In 2010 (r118866), filtering code was added to debugserver to avoid reporting threads that were "not ready to be displayed to the user". This code inspects the thread's