[Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL355458: [SBAPI] Dont check IsValid in constructor (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

JDevlieghere updated this revision to Diff 189377. JDevlieghere added a comment. - Add clone utility. - Updated other SB classes to make use of the clone function as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58946/new/ https://reviews.llvm.org/D58946 Files:

Re: [Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

On 05/03/2019 17:58, Jonas Devlieghere wrote: On Tue, Mar 5, 2019 at 8:41 AM Pavel Labath > wrote: On 05/03/2019 17:19, Jonas Devlieghere wrote: > Sounds good, I’ll make this change before landing, unless you have > further comments? > > On

Re: [Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

On Tue, Mar 5, 2019 at 8:41 AM Pavel Labath wrote: > On 05/03/2019 17:19, Jonas Devlieghere wrote: > > Sounds good, I’ll make this change before landing, unless you have > > further comments? > > > > On Tue, Mar 5, 2019 at 4:29 AM Pavel Labath via Phabricator > >

Re: [Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

On 05/03/2019 17:19, Jonas Devlieghere wrote: Sounds good, I’ll make this change before landing, unless you have further comments? On Tue, Mar 5, 2019 at 4:29 AM Pavel Labath via Phabricator mailto:revi...@reviews.llvm.org>> wrote: labath added a comment. The copy constructors and

Re: [Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

Sounds good, I’ll make this change before landing, unless you have further comments? On Tue, Mar 5, 2019 at 4:29 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > The copy constructors and assignment operators are very repetitive. What > would you

[Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58946/new/ https://reviews.llvm.org/D58946 ___

[Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

labath added a comment. The copy constructors and assignment operators are very repetitive. What would you say to a function like template void clone(std::unique_ptr , const std::unique_ptr ) { if ( == ) return; if (src) dest = llvm::make_unique(*src); else dest.reset();

[Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide, jingham. JDevlieghere added a project: LLDB. Herald added a subscriber: abidh. When running the test suite with the instrumentation macros, I noticed two lldb-mi tests regressed. The issue was the copy constructor