This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB355575: Repair the build when LLDB_DISABLE_PYTHON is set
(authored by xiaobai, committed by ).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D59056?vs=189603&id=1896
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM, Thank you for fixing this!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59056/new/
https://reviews.llvm.org/D59056
__
xiaobai updated this revision to Diff 189603.
xiaobai added a comment.
Group function registrations to cut down on ifdefs
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59056/new/
https://reviews.llvm.org/D59056
Files:
source/API/SBReproducer.cpp
Index: source/API/SBReproducer.cpp
==
JDevlieghere added inline comments.
Comment at: source/API/SBReproducer.cpp:821
(lldb::SBTypeNameSpecifier));
+#ifndef LLDB_DISABLE_PYTHON
LLDB_REGISTER_METHOD(lldb::SBTypeSummary, SBDebugger, GetSummaryForType,
The order of the met
xiaobai created this revision.
xiaobai added reviewers: JDevlieghere, labath.
If LLDB_DISABLE_PYTHON is set, some functions are unavailable but
SBReproducer assumes they are. Let's conditionally register those functions
since they are conditionally declared.
https://reviews.llvm.org/D59056
File
