[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

labath added a comment. In D59291#1438053 , @aprantl wrote: > Looks like this uncovered some UB: > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-sanitized/2050/testReport/junit/lldb-Suite/functionalities_postmortem_minidump-new/TestMiniDumpUUID_py/

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

aprantl added a comment. Looks like this uncovered some UB: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-sanitized/2050/testReport/junit/lldb-Suite/functionalities_postmortem_minidump-new/TestMiniDumpUUID_py/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5929

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

This revision was automatically updated to reflect the committed changes. Closed by commit rL356652: [Object] Add basic minidump support (authored by labath, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59291/new/ https://reviews.llvm.org/D59291 F

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

zturner accepted this revision. zturner added a comment. This LGTM, but let's give it a day to see if anyone else chimes in with comments. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59291/new/ https://reviews.llvm.org/D59291

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

labath updated this revision to Diff 190832. labath marked 8 inline comments as done. labath edited the summary of this revision. labath added a comment. - fix comments and error messages - use DenseMap Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59291/new/ http

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

labath added inline comments. Comment at: include/llvm/Object/Minidump.h:77 + ArrayRef Streams, + std::unordered_map StreamMap) + : Binary(ID_Minidump, Source), Header(Header), Streams(Streams), zturner wrote: > jhenderson wrote:

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

zturner added inline comments. Comment at: include/llvm/Object/Minidump.h:77 + ArrayRef Streams, + std::unordered_map StreamMap) + : Binary(ID_Minidump, Source), Header(Header), Streams(Streams), jhenderson wrote: > Are you delibe

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

jhenderson added a comment. I haven't really looked at the behaviour to make sure it makes sense, but I've made a number of comments on the comments and one or two other things. Comment at: include/llvm/Object/Minidump.h:25 + /// Construct a new MinidumpFile object from the g

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

labath updated this revision to Diff 190638. labath added a comment. - remove yaml stuff, making this patch only about BinaryFormat&Object changes - Add unit tests for the object layer - Add a bunch of doxygen comments - a couple of tiny implementation tweaks Repository: rL LLVM CHANGES SINCE