This revision was automatically updated to reflect the committed changes.
Closed by commit rL356703: [lldb] Add missing EINTR handling (authored by
mgorny, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258
+llvm::sys::RetryAfterSignal(-1, ::cfsetospeed,
+, B115200);
+
mgorny updated this revision to Diff 191657.
mgorny marked an inline comment as done.
mgorny added a comment.
Applied requested changes.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59606/new/
https://reviews.llvm.org/D59606
Files:
lldb/source/Host/common/PseudoTerminal.cpp
mgorny marked 3 inline comments as done.
mgorny added inline comments.
Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258
+llvm::sys::RetryAfterSignal(-1, ::cfsetospeed,
+, B115200);
+llvm::sys::RetryAfterSignal(-1,
mgorny added a comment.
Now, the curious thing is that so far I have 2 more test failures with this.
I'll investigate closer, maybe it's just flakiness.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59606/new/
https://reviews.llvm.org/D59606
labath added inline comments.
Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258
+llvm::sys::RetryAfterSignal(-1, ::cfsetospeed,
+, B115200);
+llvm::sys::RetryAfterSignal(-1, ::cfsetispeed,
+, B115200);
mgorny added inline comments.
Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258
+llvm::sys::RetryAfterSignal(-1, ::cfsetospeed,
+, B115200);
+llvm::sys::RetryAfterSignal(-1, ::cfsetispeed,
+, B115200);
mgorny updated this revision to Diff 191644.
mgorny marked 5 inline comments as done.
mgorny retitled this revision from "[lldb] [WIP/RFC] Add missing retries on
EINTR" to "[lldb] Add missing EINTR handling".
mgorny edited the summary of this revision.
mgorny added a comment.
Thanks for the
