[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

labath added a comment. In D59719#1442563 , @davide wrote: > In D59719#1441254 , @labath wrote: > > > It sounds to me like you could achieve the same thing by generalizing the > > LLDB_PYTHON_HOME logic in

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

davide added a comment. In D59719#1441254 , @labath wrote: > It sounds to me like you could achieve the same thing by generalizing the > LLDB_PYTHON_HOME logic in LLDBConfig.cmake. This would have the advantage of > centralizing the way we manage

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

davide added a comment. In D59719#1441254 , @labath wrote: > It sounds to me like you could achieve the same thing by generalizing the > LLDB_PYTHON_HOME logic in LLDBConfig.cmake. This would have the advantage of > centralizing the way we manage

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

davide added a comment. In D59719#1442181 , @ted wrote: > This doesn't look correct to me - it looks like there are 1 too many #endifs. > I think the one at line 179 should be removed - it should have been replaced > by the #else that is at line 180.

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

ted added a comment. This doesn't look correct to me - it looks like there are 1 too many #endifs. I think the one at line 179 should be removed - it should have been replaced by the #else that is at line 180. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

labath added a comment. It sounds to me like you could achieve the same thing by generalizing the LLDB_PYTHON_HOME logic in LLDBConfig.cmake. This would have the advantage of centralizing the way we manage python-finding logic (instead of each OS doing it's own thing) and also enable those

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356816: [ScriptInterpreter] Make sure that PYTHONHOME is right. (authored by davide, committed by ). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

davide updated this revision to Diff 191958. davide added a comment. Adrian's feedback Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59719/new/ https://reviews.llvm.org/D59719 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

aprantl added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:181 +#else +#if defined(__APPLE__) && PY_MAJOR_VERSION == 2 +// For Darwin, the only Python version supported is the one shipped in the OS

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

davide created this revision. davide added reviewers: jingham, friss, JDevlieghere, aprantl, jasonmolenda. Herald added subscribers: llvm-commits, jdoerfert. Herald added a project: LLVM. For the only version of Python actually supported on Darwin. rdar://problem/40961425 Repository: rL LLVM