[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

stella.stamenova added a comment. Thanks, Pavel! I tested out the proposed change and all of our Ubuntu bots now work. I've committed it as well. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60153/new/ https://reviews.llvm.org/D60153

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

labath added a comment. In D60153#1495725 , @stella.stamenova wrote: > A couple of the tests from TestVSCode_attach.py (test_by_pid and > test_by_name) are failing for us on Ubuntu because they are failing to > attach: `AssertionError: False is not

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

stella.stamenova added a comment. A couple of the tests from TestVSCode_attach.py (test_by_pid and test_by_name) are failing for us on Ubuntu because they are failing to attach: `AssertionError: False is not True : attach failed (Operation not permitted)`. It looks like attaching by pid or by

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

labath added a comment. In D60153#1469397 , @jgorbe wrote: > Thanks! Please let me know if it happens again and I'll try my best to debug > it. It is still happening (e.g. http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/141), but I already

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

jgorbe added a comment. Thanks! Please let me know if it happens again and I'll try my best to debug it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60153/new/ https://reviews.llvm.org/D60153 ___ lldb-commits

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

labath added a comment. You might be interested to know that I've just seen TestVSCode_step flake (so far just once out of ~dozen runs) locally. I've committed r357747 to get a better error message if it happens again. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

This revision was automatically updated to reflect the committed changes. jgorbe marked 2 inline comments as done. Closed by commit rL357633: Re-enable most lldb-vscode tests on Linux. (authored by jgorbe, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

jgorbe updated this revision to Diff 193585. jgorbe added a comment. Increased wait time in test binary for TestVSCode_attach.py from 5 to 10 seconds. If this is still unreliable, or it makes the test take too long, I'll switch it to use the `debugger_flag` pattern as suggested. Repository:

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

clayborg added a comment. Thanks for getting this stuff reliably working. I debug using VS Code every day using lldb-vscode and it is my favorite LLDB based debugger! I look forward to seeing support for Windows and linux being tested and available. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

jgorbe created this revision. jgorbe added reviewers: zturner, clayborg. Herald added a project: LLDB. After https://reviews.llvm.org/D59828 and https://reviews.llvm.org/D59849, I believe the problems with these tests hanging have been solved. I tried enabling all of them on my machine, and got