This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB361898: Fix IPv6 support on lldb-server platform
(authored by aadsm, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61833?vs=200562=201784#toc
Repository:
rLLDB LLDB
CHANGES
aadsm updated this revision to Diff 200562.
aadsm added a comment.
A-Z order the CMakeLists files
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61833/new/
https://reviews.llvm.org/D61833
Files:
labath added inline comments.
Comment at: lldb/unittests/Host/CMakeLists.txt:12-13
TaskPoolTest.cpp
+ SocketTestUtilities.cpp
+ ConnectionFileDescriptorTest.cpp
)
Please sort this list before committing.
Repository:
rG LLVM Github Monorepo
CHANGES
aadsm updated this revision to Diff 200353.
aadsm edited the summary of this revision.
aadsm added a comment.
- Fixed function from const to static (mea culpa)
- Fixed inet_pton usage on windows
- Fixed issue with GetURL return creating a temp object
Repository:
rG LLVM Github Monorepo
labath added inline comments.
Comment at: unittests/Host/ConnectionFileDescriptorTest.cpp:41
+llvm::StringRef path;
+EXPECT_TRUE(UriParser::Parse(connection_file_descriptor.GetURI(), scheme,
+ hostname, port, path));
xiaobai added a comment.
This broke windows buildbots. I tried to fix with svn r361083 but there were
other things that got broken. @aadsm: We should revisit this patch next week
and see what we need to fix up before it goes in.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB361079: Fix IPv6 support on lldb-server platform
(authored by xiaobai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61833?vs=199619=200108#toc
Repository:
rLLDB LLDB
xiaobai added a comment.
Landed -- r361079
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61833/new/
https://reviews.llvm.org/D61833
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
aadsm updated this revision to Diff 199619.
aadsm added a comment.
Move function from anonymous namespace to const
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61833/new/
https://reviews.llvm.org/D61833
Files:
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks fine to me. Thank you for fixing this.
Comment at: lldb/unittests/Host/SocketTestUtilities.cpp:16
+namespace {
+void AcceptThread(Socket *listen_socket, bool
aadsm updated this revision to Diff 199331.
aadsm added a comment.
Use functions instead of subclassing
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61833/new/
https://reviews.llvm.org/D61833
Files:
labath added a comment.
The actual change looks obviously correct. Below are my comments on the test
situation.
> I wanted to reuse the CreateConnectedSockets part of the SocketTests.
> Initially I thought about creating a few functions in a test socket utility
> file, but then I realized the
aadsm created this revision.
aadsm added a reviewer: labath.
Herald added subscribers: lldb-commits, jfb, mgorny.
Herald added a project: LLDB.
This is a general fix for the ConnectionFileDescriptor class but my main
motivation was to make lldb-server working with IPv6.
The connect URI can use
13 matches
Mail list logo
