This revision was automatically updated to reflect the committed changes.
Closed by commit rL360872: DWARF: Add ability to reference debug info coming
from multiple sections (authored by labath, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior
labath updated this revision to Diff 199562.
labath marked 4 inline comments as done.
labath added a comment.
- use enum class for the section type
- put DIERef as a member of HashedNameToDie::DIEInfo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61908/new/
labath marked 10 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:18
if (form_value.IsValid()) {
const DWARFUnit *dwarf_cu = form_value.GetCompileUnit();
if (dwarf_cu) {
clayborg wrote:
>
clayborg added a comment.
See inline comments. Nice patch overall though, real close.
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:18
if (form_value.IsValid()) {
const DWARFUnit *dwarf_cu = form_value.GetCompileUnit();
if (dwarf_cu) {
We
