This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB361999: [Target] Introduce Process::GetLanguageRuntimes
(authored by xiaobai, committed by ).
Herald added a project: LLDB.
Changed prior to commit:
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62562/new/
https://reviews.llvm.org/D62562
___
lldb-commits mailing list
xiaobai updated this revision to Diff 201959.
xiaobai added a comment.
Address review feedback
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62562/new/
https://reviews.llvm.org/D62562
Files:
include/lldb/Target/Language.h
include/lldb/Target/Process.h
source/Target/Language.cpp
labath added inline comments.
Comment at: source/Target/Process.cpp:1565
+ for (const lldb::LanguageType lang_type : Language::GetSupportedLanguages())
{
+if (auto runtime = GetLanguageRuntime(lang_type, retry_if_null))
+
JDevlieghere added inline comments.
Comment at: source/Target/Thread.cpp:2216
+ GetProcess()->GetLanguageRuntimes();
+ for (LanguageRuntime *runtime : language_runtimes) {
+if (!runtime)
if ` for (LanguageRuntime *runtime :
xiaobai created this revision.
xiaobai added reviewers: JDevlieghere, davide, jingham.
Currently there's not really a good way to iterate over the language runtimes a
process has. This is sometimes desirable (as seen in my change to Thread).
Additionally, there's not really a good reason to
