simoncook updated this revision to Diff 205287.
simoncook added a comment.
- Refactored register tables to match style used in i386/x86_64
- Add enum for RISC-V DWARF numbers
- Add F registers (assuming 32-bit, at runtime this seems to be overwritten to
64-bit if D extension is provided)
- Add
jasonmolenda added inline comments.
Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:624-635
+case llvm::Triple::riscv32:
+case llvm::Triple::riscv64:
+ for (auto : m_regs) {
+if (strcmp(reg.name, "x1") == 0)
+
clayborg added a comment.
Jason, can you take a look at "Thread.cpp" and my inlined comment?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62732/new/
https://reviews.llvm.org/D62732
___
lldb-commits
xiaobai added subscribers: compnerd, xiaobai.
xiaobai added a reviewer: compnerd.
xiaobai added a comment.
@compnerd You might be interested in this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62732/new/
https://reviews.llvm.org/D62732
clayborg added a comment.
You are following all of the patterns for all of the architectures. It would be
nice for us to cleanup DynamicRegisterInfo.cpp, Platform.cpp, and Thread.cpp
eventually so we don't need to modify these files when a few arch is added by
abstracting things into
simoncook created this revision.
simoncook added reviewers: asb, lewis-revill.
Herald added subscribers: benna, psnobl, jocewei, PkmX, rkruppe, the_o,
brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,
kito-cheng, niosHD, sabuasal, apazos, johnrusso, rbar, mgorny.
