[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

2019-08-07 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL368151: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

2019-08-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Okay, sounds like the best possible solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65566/new/

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

2019-08-06 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added a comment. Solutions are clearly favorable over workarounds like this, but I couldn't find one. Xcode has a mechanism called `sign on copy` which seems to be the native way to avoid this problem, but I couldn't get it to work with LLDB, because I want to copy the build output

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

2019-08-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D65566#1612051 , @sgraenitz wrote: > In D65566#1611007 , @JDevlieghere > wrote: > > > Is there a way to use the debugserver in the framework instead? > > > This patch is about the

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

2019-08-02 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added a comment. In D65566#1611007 , @JDevlieghere wrote: > Is there a way to use the debugserver in the framework instead? This patch is about the debugserver in the framework. It must be signed, because the lldb driver uses it implicitly

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

2019-08-01 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Is there a way to use the debugserver in the framework instead? This seems like the inverse of the problem we had earlier with the RPATHs, where we would fix them up in the build tree after copying them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

2019-08-01 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz marked an inline comment as done. sgraenitz added a comment. Checked with: > xcodebuild -configuration Release -target debugserver > codesign -dv Release/bin/LLDB.framework/Versions/A/Resources/debugserver > codesign -dv Release/bin/debugserver Comment at:

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

2019-08-01 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. sgraenitz added reviewers: jingham, davide, JDevlieghere, teemperor. Herald added a subscriber: mgorny. Herald added a project: LLDB. sgraenitz edited the summary of this revision. Explicitly code-sign the LLDB.framework copy of debugserver in the build-tree.