labath added a comment.
(I eventually decided to skip the test, as without the extra flag, the same
functionality can be exercised in a much more conventional way with "image
lookup -a")
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65647/new/
This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL367983: Fix line table resolution near the end of a section
(authored by labath, committed by ).
Herald added a project: LLVM.
Herald added a subscriber:
labath updated this revision to Diff 213342.
labath added a comment.
Herald added a reviewer: jdoerfert.
- redo the patch to keep the logic inside the line table code. I've been
considering whether to do that my self. On one hand, this functionality seems
like it could be useful in other places,
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I vote to not add any API calls with allow_section_end and just take care of
this in source/Symbol/LineTable.cpp. All of my inline comments will reflect
this notion.
labath created this revision.
labath added reviewers: clayborg, jingham.
Herald added a subscriber: mgorny.
lld r367537 changed the way the linker organizes sections and segments.
This exposed an lldb bug and caused some tests to fail.
In all of the failing tests the root cause was the same --
