[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

This revision was automatically updated to reflect the committed changes. Closed by commit rL372210: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I'm happy with this, and it looks very nice and idiomatic, but maybe wait for @compnerd a bit, as he had some reservations about the whole thing.. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz updated this revision to Diff 214139. sgraenitz added a comment. Achieve the same via extra `HINT` to `find_package(Clang ...)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65798/new/ https://reviews.llvm.org/D65798 Files:

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz added a comment. In D65798#1618609 , @labath wrote: > Making it so that the clang is automatically found it if happens to be next > to llvm seems like a reasonable thing to me. I have no idea what would be the > canonical cmake way to do

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz updated this revision to Diff 213842. sgraenitz added a comment. Update documentation to mention multiple provided build trees and the usage of `Clang_DIR` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65798/new/

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

labath added a comment. Making it so that the clang is automatically found it if happens to be next to llvm seems like a reasonable thing to me. I have no idea what would be the canonical cmake way to do that... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") labath wrote: > sgraenitz wrote: > >

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz added a comment. What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65798/new/ https://reviews.llvm.org/D65798 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz updated this revision to Diff 213834. sgraenitz added a comment. Change comment and condition to only infer Clang_DIR if it exists. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65798/new/ https://reviews.llvm.org/D65798 Files:

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

labath added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") sgraenitz wrote: > compnerd wrote: > >

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") compnerd wrote: > sgraenitz wrote: > >

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

compnerd added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") sgraenitz wrote: > compnerd wrote: > > What

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") compnerd wrote: > What happens in the

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

compnerd added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:6 + # next to LLVM's module directory. + set(Clang_DIR ${LLVM_DIR}/../clang) + message(STATUS "Inferred Clang_DIR: ${Clang_DIR}") What happens in the standalone clang build

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, jingham, xiaobai, compnerd, labath. Herald added a subscriber: mgorny. Herald added a project: LLDB. This shrinks standalone configuration lines by one more parameter. In the provided build-tree, the default structure of