[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rL368125: Detect HAVE_SYS_TYPES_H in lldb (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Woops, this is quite embarrassing. :/ One day we should audit these to check which of these files really needs to include this header, but since there are at least some files that definitely

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213726. hhb added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

srhines added inline comments. Comment at: lldb/include/lldb/Host/windows/PosixApi.h:56 #endif #endif // __MINGW32__ Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213689. hhb added a comment. Herald added a subscriber: mstorsjo. Add one more place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files:

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb added a comment. I'm not really know how this works before, given no one includes Config.h. Or maybe sys/types.h is never needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213688. hhb added a comment. Remove test code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213687. hhb added a comment. Remove a test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. After rL368069 I noticed that HAVE_SYS_TYPES_H is not defined in Platform.h, or anywhere else in lldb. This change fixes