[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

This revision was automatically updated to reflect the committed changes. Closed by commit rL370571: [lldb] Unify target checking in CommandObject (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

teemperor updated this revision to Diff 218117. teemperor marked 3 inline comments as done. teemperor added a comment. - Fix typo in code and comment. - Reflow some changed strings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66863/new/ https://reviews.llvm.org/D66863 Files:

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a few string reflows and fix a typo Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:593 + : CommandObjectParsed(interpreter,

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

teemperor updated this revision to Diff 218084. teemperor added a comment. - Removed target requirement where we already have another flag that's implying that we need a target. - Properly formatted some strings. - Extended check in GetSelectedTarget to also check for flags that imply

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome. In D66863#1649436 , @jingham wrote: > As a minor style thing, prior to this change CommandObjectThreadStepUntil > required a thread, but

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

jingham added a comment. Herald added a subscriber: JDevlieghere. The whole command flags was a late addition, but we were using it for new commands and "when you touch it" kind of changes. That seems to have stalled the conversion, so thanks for completing this! As a minor style thing, prior

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

amccarth added a comment. I support anything that reduces the code path differences between user-entered commands and their SBAPI counterparts. Thanks for doing this! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66863/new/ https://reviews.llvm.org/D66863

[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. We currently have several CommandObjects that manually reimplement the checking for a selected target or a target in the execution context (which is