[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

This revision was automatically updated to reflect the committed changes. Closed by commit rL371090: Fix windows-x86-debug compilation with python enabled using multi-target… (authored by amccarth, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

amccarth added a comment. Yes, I can commit it for you soon. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy added a comment. Thanks for the review! Can somebody commit this please because I don't have commit access? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks for factoring out the duplication. Fingers crossed. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

labath added a comment. Thanks. The new version seems fine to me. I'll leave it for the windows folks to have the final say on this.. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy updated this revision to Diff 218877. leonid.mashinskiy added a comment. Extracted python lookup logic into function Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994 Files:

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

amccarth added a comment. I'm open to this if we can reduce the code duplication. One of my concerns is that changes in July and August completely broke the build for me for many days. I had to remove all but one version of Python to ensure that it always found the right one. I, too, would

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy added a comment. Since this patch appeared to be arguable from your point of view I will write some comments before making any further changes. In D66994#1652868 , @amccarth wrote: > - I use the VS project only for code browsing and

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

amccarth requested changes to this revision. amccarth added inline comments. This revision now requires changes to proceed. Comment at: cmake/modules/LLDBConfig.cmake:164 # if(CMAKE_MSVC_RUNTIME_LIBRARY MATCHES MultiThreadedDebug) - if(CMAKE_BUILD_TYPE STREQUAL Debug) -

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

stella.stamenova added a comment. Is there a way to reduce some of the code duplication? The more duplication there is, the harder it is to maintain. Comment at: cmake/modules/LLDBConfig.cmake:240 + if (NOT DEFINED CMAKE_BUILD_TYPE) +# multiconfiguration generator was

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

amccarth added a comment. I'll look at this in detail soon, but a few caveats: - lldb tests don't work with the debug Python interpreter, which is why I've been complaining about test failures approximately forever when the bots seem fine. - Some of these changes you're undoing caused a lot

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

labath added reviewers: amccarth, stella.stamenova. labath added a comment. +windows folks, then can speak to the substance of this change. As for the implementation, I get the impression that there is a lot of duplicated code in here. The code for finding the release and debug pythons is

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy created this revision. leonid.mashinskiy added reviewers: labath, JDevlieghere. leonid.mashinskiy added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. Visual Studio CMake generator is multi-target and does not define CMAKE_BUILD_TYPE, so Debug build on VS was