This revision was automatically updated to reflect the committed changes.
Closed by commit rL372486: [LLDB] Cast -1 (as invalid socket) to the socket
type before comparing (authored by mstorsjo, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior
mstorsjo updated this revision to Diff 221122.
mstorsjo added a comment.
Use static_cast.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67863/new/
https://reviews.llvm.org/D67863
Files:
lldb/source/Host/common/Socket.cpp
lldb/tools/lldb-vscode/lldb-vscode.cpp
Index:
compnerd added inline comments.
Comment at: lldb/source/Host/common/Socket.cpp:479
}
- NativeSocket fd = llvm::sys::RetryAfterSignal(-1, ::accept4,
+ NativeSocket fd = llvm::sys::RetryAfterSignal((NativeSocket) -1, ::accept4,
sockfd, addr, addrlen, flags);
mstorsjo created this revision.
mstorsjo added reviewers: hhb, labath, compnerd.
Herald added subscribers: JDevlieghere, abidh.
Herald added a project: LLDB.
This silences warnings about comparison of integers between unsigned long long
(which is what the Windows SOCKET type is) and signed int
