[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG0891366571b2: [Windows] Introduce a switch for the `lldb-server` mode on Windows (authored by aleksandr.urakov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. Hello! I am sorry for a delay with reply, I was OOO. Thanks all for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258 ___

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

amccarth accepted this revision. amccarth added a comment. Given Pavel's comment, this LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

labath added a comment. In D68258#1691485 , @amccarth wrote: > The environment variable for using the native PDB was always intended to be > temporary, since the native PDB reader would eventually be the only PDB > reader. I don't know whether that's

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

amccarth added a comment. In D68258#1690757 , @aleksandr.urakov wrote: > In D68258#1690756 , > @aleksandr.urakov wrote: > > > I've made it in the way similar to Zachary have made for the > >

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. In D68258#1690756 , @aleksandr.urakov wrote: > I've made it in the way similar to Zachary have made for the > `SymbolFileNativePDB` plugin. An environment variable could be more > convenient e.g. to run a bunch of

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. I've made it in the way similar to Zachary have made for the `SymbolFileNativePDB` plugin. An environment variable could be more convenient e.g. to run a bunch of tests using the `lldb-test` option. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

amccarth added a comment. Why an environment variable rather than a command line option? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds reasonable. Thanks for doing this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: labath, amccarth, asmith, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh. This patch introduces a switch, based on the environment variable